feat(app_dsl_service): enhance error handling and DSL version management #10108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use more specific error classes for various DSL import errors. - Move `_check_or_fix_dsl` function to a standalone utility for better separation of concerns. - Introduce `_check_or_fix_dsl` tests to validate DSL version handling. - Replace `from_model_config_dict` parameter type with `Mapping[str, Any]` for improved type hint accuracy. - Utilize `ssrf_proxy` for more secure HTTP requests in AppDslService.
dosubot
bot
added
size:L
crazywoola
approved these changes
Oct 31, 2024
crazywoola
deleted the
feat/enhance-error-handling-and-DSL-version-management
branch
Nov1c444
pushed a commit
that referenced
this pull request
Nov 5, 2024
iamjoel
pushed a commit
that referenced
this pull request
Nov 7, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
_check_or_fix_dslfunction to a standalone utility for better separation of concerns._check_or_fix_dsltests to validate DSL version handling.from_model_config_dictparameter type withMapping[str, Any]for improved type hint accuracy.ssrf_proxyfor more secure HTTP requests in AppDslService.Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration