Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize unique document filtering with set #10082

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

y-omr
Copy link
Contributor

@y-omr y-omr commented Oct 30, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

In this refactoring, I made the following improvements:

Simplification of Duplicate Loops:

In the original code, dify_documents and external_documents were processed separately, leading to redundancy. After refactoring, the entire documents list is processed in a single loop with branching based on the provider.

Efficient Management of Unique Documents:

To manage unique document IDs, I changed the data structure from a list to a set (doc_id). Using a set allows for faster duplicate checks (O(1)), thereby enhancing performance.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 30, 2024
@crazywoola crazywoola requested a review from JohnJyong October 31, 2024 01:54
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 31, 2024
@JohnJyong JohnJyong merged commit 11ca1be into langgenius:main Oct 31, 2024
6 checks passed
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants