Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conversation variable may not change in the answer node #10034

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Oct 30, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Reproduce

  1. create a chatflow with three nodes: start, variable assigner, answer
  2. create a conversation variable, in the variable assigner node change the variable, in the answer node output the variable
  3. in the debug and preview panel , will always output the previous variable value.

image
4c9e365d46e221dde8a3038a414235d

reproduce DSL: test.zip

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

test locally

  • Test the reproduce DSL above
  • Test a variable assigner node and a LLM node, and combine the results in the answer node

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 30, 2024
@hjlarry
Copy link
Contributor Author

hjlarry commented Oct 30, 2024

cc @crazywoola @laipz8200

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
@crazywoola crazywoola merged commit c7fb8a4 into langgenius:main Oct 30, 2024
6 checks passed
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants