Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OceanBase as an option for the vector store in Dify #10010

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

powerfooI
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR added OceanBase CE as an option for the vector store in Dify.

Fixes #9982.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

I have set VECTOR_STORE=oceanbase to enable oceanbase to act as the vector store of dify and tested functionalities of datasets. Creating dataset, uploading documents, retrieving chunks and deleting dataset work as expected.

The followings are screenshots of the test,

image Pasted Graphic 1

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Oct 29, 2024
crazywoola
crazywoola previously approved these changes Oct 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@JohnJyong
Copy link
Collaborator

pls fix your style check and api test, thanks

@powerfooI
Copy link
Contributor Author

powerfooI commented Oct 29, 2024

pls fix your style check and api test, thanks

OK. I've fixed it. Sorry for forgetting to update poetry.lock and reformat the code after fixing the newest conflicts.

@crazywoola crazywoola merged commit 878d13e into langgenius:main Oct 29, 2024
6 checks passed
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@powerfooI powerfooI deleted the vdb/oceanbase branch February 6, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add support for oceanbase as vector database
3 participants