The parameter 'name' in the 'update-by_file' API is incorrectly overwritten by the file name of 'file'.

[glacierck]

Self Checks

• This is only for bug report, if you would like to ask a question, please head to Discussions.
• I have searched for existing issues search for existing issues, including closed ones.
• I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
• [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
• Please do not modify this template :) and fill in all the required fields.

Dify version

0.9.1

Cloud or Self Hosted

Self Hosted (Docker)

Steps to reproduce

send
curl --location --request POST 'http://192.168.1.210/v1/datasets/{dataset_id}/documents/{document_id}/update_by_file' \ --header 'Authorization: Bearer {api_key}' \ --form 'data="{"name":"A.txt","indexing_technique":"high_quality"}";type=text/plain' \ --form 'file=@"/B.txt"'

✔️ Expected Behavior

The document is named A.txt

❌ Actual Behavior

The document is named B.txt

[dosubot]

The 'name' parameter in the 'update-by_file' API is being overwritten by the file name because the API prioritizes the uploaded file's name over the specified 'name' parameter. To explicitly set the document name and prevent it from being overwritten, ensure you include the name parameter in the request body. Here's an example:

curl --location --request POST 'http://192.168.1.210/v1/datasets/{dataset_id}/documents/{document_id}/update_by_file' \
--header 'Authorization: Bearer {api_key}' \
--form 'data="{\"name\":\"A.txt\",\"indexing_technique\":\"high_quality\"}";type=text/plain' \
--form 'file=@"/B.txt"'

Make sure the name parameter is correctly formatted in the JSON data ^[1].

To continue talking to Dosu, mention @dosu.

[glacierck]

@dosu After determining the format, there is still an error overwrite

[dosubot]

The 'name' parameter might still be overwritten because the backend logic does not explicitly handle it when updating a document by file. The code focuses on the file upload and may default to using the file name if the 'name' parameter isn't processed correctly. Ensure that the backend logic explicitly updates the document's name with the provided 'name' parameter ^[1].

To continue talking to Dosu, mention @dosu.

[crazywoola]

Is this a duplicated #9177 issue?

[crazywoola]

This is an expected behavior according to our dev team.

[glacierck]

@crazywoola Not the same one，#9177 is related to the issue with the 'creat-by_file' interface, while the current issue is related to the 'update-by_file', where the parameter 'name' is invalid.

[glacierck]

This is an expected behavior according to our dev team.

I can't imagine what the expected design goal is. If I only expect to overlay content onto existing documents through files as a carrier, the most basic thing is not to simply provide content overlay, rather than overwriting the name of the original file? Even when I don't submit a 'name', I should keep the original file name instead of being overwritten by a new file name.