Skip to content

fix issue 2975 #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

gkwan-ibm
Copy link
Contributor

@gkwan-ibm gkwan-ibm commented May 14, 2025

Issue

Closes #2975

Change

Because the HuggingFace pipeline/feature-extraction API was changed, the test or the embed call failed. See the post at https://huggingface.co/sentence-transformers/all-MiniLM-L6-v2/discussions/115#6824b067f13f465f51eb1ea9

General checklist

  • There are no breaking changes
    • Only a single change. Assume it does not break other
  • I have added unit and/or integration tests for my change
    • No need because existing tests already cover
  • The tests cover both positive and negative cases
    • No need because existing tests already cover
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
    • ran: cd langchain4j-hugging-face, mvn clean, mvn verify
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green
    • Only tested langchain4j-hugging-face because the fix only applies to langchain4j-hugging-face and I have no access others.

Checklist for adding new maven module

  • I have added my new module in the root pom.xml and langchain4j-bom/pom.xml
    • no new module

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
    • not apply
  • I have added a {NameOfIntegration}EmbeddingStoreRemovalIT that extends from EmbeddingStoreWithRemovalIT
    • not apply

Checklist for changing existing embedding store integration

  • I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j
    • not apply

Signed-off-by: Gilbert Kwan <[email protected]>
@gkwan-ibm gkwan-ibm marked this pull request as draft May 14, 2025 18:37
@gkwan-ibm
Copy link
Contributor Author

gkwan-ibm commented May 14, 2025

The PR is ready for review.

The fix is very simple. Don't know why some checks failed.

@vjuranek
Copy link

+1, just wanted to send the same PR. The URL has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] langchain4j-hugging-face test failed
2 participants