Skip to content

feat(google-genai): Add baseUrl property to embeddings #8235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

schrothbn
Copy link
Contributor

Small addition of the baseUrl property that already exists on the google-genai chat model to the embeddings. This should enable the use of proxies / custom base urls as it's already supported on the chat model.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 22, 2025
Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 22, 2025 9:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) May 22, 2025 9:08am

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label May 22, 2025
@OlegIvaniv
Copy link
Contributor

OlegIvaniv commented Jun 16, 2025

@hntrl Any thoughts on this one? Would appreciate if we could get this in as it's a blocker for us

Copy link
Contributor

@hntrl hntrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schrothbn thanks for the PR!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jun 16, 2025
@hntrl hntrl merged commit 8481891 into langchain-ai:main Jun 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants