fix(langchain): vertex ai model name pulled from hub #8159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
size:XS
| @@ -106,7 +106,7 @@ export function generateModelImportMap( | |||
| importMapKey = "chat_models__anthropic"; | |||
| } else if (modelLcName === "ChatAzureOpenAI") { | |||
| importMapKey = "chat_models__openai"; | |||
| } else if (modelLcName === "ChatGoogleVertexAI") { | |||
| } else if (modelLcName === "ChatVertexAI") { | |||
There was a problem hiding this comment.
probably neither here nor there w.r.t. this change, but interesting that we don't support vertex web here (cc @afirstenberg).
There was a problem hiding this comment.
Both of them use the same lc_name and Class name, and python doesn't distinguish between the two.
Certainly part of a much bigger discussion that we need to have at some point.
|
Thanks for the fix, @anadi45! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (#8136)
ChatGoogleVertexAIwas incorrect and should beChatVertexAI