Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openai): ensure that we're not sending stream: true even if streaming is not being done #7959

Merged
merged 3 commits into from
Apr 4, 2025
Merged

fix(openai): ensure that we're not sending stream: true even if streaming is not being done #7959

merged 3 commits into from
Apr 4, 2025
+5 −4

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented Apr 3, 2025

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 2:25pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Apr 4, 2025 2:25pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 3, 2025
jacoblee93
jacoblee93 approved these changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added lgtm PRs that are ready to be merged as-is auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Apr 3, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 4, 2025
@dqbd dqbd merged commit 2bb45a4 into main Apr 4, 2025
10 of 13 checks passed
@dqbd dqbd deleted the dqbd/oai-force-disable-streaming branch April 4, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dqbd @jacoblee93