fix(core): Add typing in ChatMessagePromptTemplate.fromTemplate #7874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the static method fromTemplate, this PR allows the type of the input to be strictly enforced.
When using the following example :
If an input is missing you got a type error
Property 'foo' is missing in type '{ bar: string; }' but required in type 'TypedPromptInputValues<{ foo: string; bar: string; }>'
I have reused the declarations found in
PromptTemplate.fromTemplate
with the eslint-disabled for the banned typeSymbol
to stay consistent.Let me know if you have any feedback.
Thanks for the great work !