Skip to content

Configure lint-staged precommit on all workspaces #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

tyleralves
Copy link
Contributor

Closes #44

Only include lint-staged in top-level package.json as outlined in docs: https://github.com/okonet/lint-staged#how-to-use-lint-staged-in-a-multi-package-monorepo

Moves lint-staged config to top-level package.json since the same configuration works for all workspaces. lint-staged discovers the closest configuration to each staged file, so workspace specific configs can be added in the future if there are conflicts with the global config.

Only include lint-staged in top-level package.json as outlined in docs:
https://github.com/okonet/lint-staged#how-to-use-lint-staged-in-a-multi-package-monorepo

Moves lint-staged config to top-level package.json since the same
configuration works for all workspaces. lint-staged discovers the closest
configuration to each staged file, so workspace specific configs can be
added in the future if there are conflicts with the global config.
@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 7, 2023 6:54am

@nfcampos nfcampos added the lgtm PRs that are ready to be merged as-is label Apr 8, 2023
@nfcampos nfcampos merged commit 6ec08c5 into langchain-ai:main Apr 8, 2023
@nfcampos
Copy link
Collaborator

nfcampos commented Apr 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lint-staged to docs and examples packages
2 participants