Skip to content

google[patch]: fix: handling multibyte characters in stream for google-vertexai-web #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

pokutuna
Copy link
Contributor

Fixes #6501

I have fixed this issue similarly to #5286.
The approach is the same, but we need to use components that work in the Browser environment instead of Node.

I previously fixed the same issue for @langchain/google-vertexai in #5285.
Although I don't use @langchain/google-vertexai-web myself, I've also fixed this package as it was requested in the issue.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 12, 2024
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 9:29am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 13, 2024 9:29am

@jacoblee93
Copy link
Collaborator

Thank you very much!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Aug 13, 2024
@jacoblee93 jacoblee93 changed the title fix: handling multibyte characters in stream for google-common & google-vertexai-web google[patch]: fix: handling multibyte characters in stream for google-vertexai-web Aug 13, 2024
Copy link

vercel bot commented Aug 13, 2024

@pokutuna is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@pokutuna
Copy link
Contributor Author

Thanks for the review. Fixed import extension due to CI failure.
https://github.com/langchain-ai/langchainjs/actions/runs/10355951673/job/28696604322

CI is still failing, but I can't access Vercel details.
Any advice on what I should fix would be appreciated.

@jacoblee93
Copy link
Collaborator

jacoblee93 commented Aug 13, 2024

It's not you, we're hitting some rate limits for API refs. Will merge and ship tomorrow.

Thanks again!

@jacoblee93 jacoblee93 merged commit e029d5e into langchain-ai:main Aug 16, 2024
25 of 26 checks passed
@jacoblee93
Copy link
Collaborator

Sorry for the delay, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacement Character(�) appears in multibyte text output from Google VertexAI Web
2 participants