Skip to content

redis[patch]: Adds a connection pool to RedisChatHistory #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/langchain-redis/src/chat_histories.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
createClient,
RedisClientOptions,
RedisClientType,
RedisModules,
Expand All @@ -12,6 +11,7 @@ import {
mapChatMessagesToStoredMessages,
mapStoredMessagesToChatMessages,
} from "@langchain/core/messages";
import { pool } from "./connections.js";

/**
* Type for the input to the `RedisChatMessageHistory` constructor.
Expand Down Expand Up @@ -68,7 +68,7 @@ export class RedisChatMessageHistory extends BaseListChatMessageHistory {
super(fields);

const { sessionId, sessionTTL, config, client } = fields;
this.client = (client ?? createClient(config ?? {})) as RedisClientType<
this.client = (client ?? pool.getClient(config)) as RedisClientType<
RedisModules,
RedisFunctions,
RedisScripts
Expand Down
14 changes: 14 additions & 0 deletions libs/langchain-redis/src/connections.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { createClient, RedisClientOptions } from "redis";

// A minimalistic connection pool to avoid creating multiple connections
class RedisConnectionPool {
clients = new Map();

getClient(config: RedisClientOptions = {}) {
if (!this.clients.has(config))
this.clients.set(config, createClient(config));
return this.clients.get(config);
}
}

export const pool = new RedisConnectionPool();
Loading