Skip to content

google-common[patch]: remove all additionalProperties for gemini #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

google-common[patch]: remove all additionalProperties for gemini #5247

merged 1 commit into from
Apr 30, 2024

Conversation

jeasonnow
Copy link
Contributor

Fixes #5240

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 29, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:14am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 30, 2024 2:14am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Apr 29, 2024
@bracesproul bracesproul changed the title fix: #5240 remove all additionalProperties for gemini google-common[patch]: remove all additionalProperties for gemini Apr 29, 2024
bracesproul
bracesproul reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comment, it looks good. Please re-request my review once you've responded.

Thanks for taking this on!

cc @afirstenberg

@bracesproul bracesproul added the question Further information is requested label Apr 29, 2024
@afirstenberg
Copy link
Contributor

Oh wow, I didn't expect someone to tackle this so quickly. I mostly opened the issue to remind myself to get to it eventually. Thank you, @jeasonnow.

@jeasonnow jeasonnow force-pushed the fix/5240 branch 2 times, most recently from 8cda51e to 5b23814 Compare April 30, 2024 01:58
bracesproul
bracesproul approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for handling this one!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Apr 30, 2024
@bracesproul bracesproul merged commit bf92eaa into langchain-ai:main Apr 30, 2024
17 checks passed
@jeasonnow jeasonnow deleted the fix/5240 branch May 2, 2024 09:41
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
@Avish24x Avish24x mentioned this pull request Jun 20, 2024
Open
@necaris necaris mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afirstenberg afirstenberg afirstenberg left review comments

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is question Further information is requested size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google-common [bug]: zodToGeminiParameters leaves in some additionalProperties
3 participants
@jeasonnow @afirstenberg @bracesproul