Skip to content

community[patch]: ensure AstraDB createCollectionOptions are aligned with py version #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

nicoloboschi
Copy link
Contributor

Same indexing default as python langchain.
Also fixes a rebase issue after #5170 and #5142

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 23, 2024
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:14pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 23, 2024 2:14pm

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Apr 23, 2024
@jacoblee93 jacoblee93 changed the title community[fix]: ensure AstraDB createCollectionOptions are aligned with py version community[patch]: ensure AstraDB createCollectionOptions are aligned with py version Apr 23, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit 5f96f4a into langchain-ai:main Apr 24, 2024
jeasonnow pushed a commit to jeasonnow/langchainjs that referenced this pull request Apr 25, 2024
…with py version (langchain-ai#5185)

* community[fix]: ensure AstraDB createCollectionOptions are aligned with py version

* fix

* fix
@nicoloboschi nicoloboschi mentioned this pull request May 14, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants