Skip to content

core: Add ruff rules FBT001 and FBT002 #30695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Apr 6, 2025

Add ruff rules FBT001 and FBT002.
Mostly noqas to not introduce breaking changes and possible non-breaking fixes have already been done in a previous PR.
These rules will prevent new violations to happen.

Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2025 0:08am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. langchain Related to the langchain package 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Apr 6, 2025
@cbornet cbornet force-pushed the ruff-core-fbt-1-2 branch from 6dc65bc to 56b15a9 Compare April 6, 2025 08:32
@cbornet cbornet requested a review from eyurtsev April 6, 2025 08:59
@cbornet cbornet force-pushed the ruff-core-fbt-1-2 branch from 56b15a9 to c272b3c Compare April 10, 2025 08:37
Copy link

codspeed-hq bot commented Apr 10, 2025

CodSpeed Performance Report

Merging #30695 will not alter performance

Comparing cbornet:ruff-core-fbt-1-2 (c272b3c) with master (63c16f5)

Summary

✅ 8 untouched benchmarks

@cbornet cbornet force-pushed the ruff-core-fbt-1-2 branch from c272b3c to 5e6ef0a Compare April 11, 2025 08:56
@cbornet cbornet force-pushed the ruff-core-fbt-1-2 branch from 5e6ef0a to 48c94da Compare April 11, 2025 12:08
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 11, 2025
@eyurtsev eyurtsev merged commit 913c896 into langchain-ai:master Apr 11, 2025
74 checks passed
@cbornet cbornet deleted the ruff-core-fbt-1-2 branch April 11, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants