Update qdrant.py #1088
Merged
Update qdrant.py #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
approved these changes
Feb 16, 2023
|
@rishabh-ti That's actually causing the issue, not solving it. Qdrant stores the document content with "page_content" key (check out https://github.com/hwchase17/langchain/blob/6322b6f657b8f630c72d6c321ece0e513b2ba35f/langchain/vectorstores/qdrant.py#L218). If you now read it from a different key, then you break the integration. @hwchase17 Can we revert those changes? I want to verify the root cause and provide a fix, but that PR actually introduces the same bug like described in #1087 |
kacperlukawski
added a commit
to kacperlukawski/langchain
that referenced
this pull request
Feb 16, 2023
dongreenberg
pushed a commit
to dongreenberg/langchain
that referenced
this pull request
Feb 17, 2023
Closed
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
…in-ai#1093) The langchain-ai#1088 introduced a bug in Qdrant integration. That PR reverts those changes and provides class attributes to ensure consistent payload keys. In addition to that, an exception will be thrown if any of texts is None (that could have been an issue reported in langchain-ai#1087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087