[vertexai]: ignore empty AIMessage from previous blocked responses #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuligin
reviewed
May 19, 2025
lkuligin
reviewed
May 19, 2025
| @@ -357,6 +357,12 @@ def _convert_to_parts(message: BaseMessage) -> List[Part]: | |||
| prev_ai_message = message | |||
| role = "model" | |||
|
|
|||
| # Previous blocked messages will have empty content which should be ignored | |||
| if not message.content and message.response_metadata.get( | |||
| "is_blocked", False | |||
There was a problem hiding this comment.
should it be message.response_metadata.get("is_blocked", True) instead maybe?
There was a problem hiding this comment.
I was thinking that if someone does this by accident it's better to let the API yell at them than sanitize the data
model.invoke([AIMessage(content="")])But whatever you think is best, maybe there are other cases where the content is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Filter out any
AIMessagefrom previous blocked interactions with a model. See issue description for details of when this comes up.Other messages with empty content will still be passed through and error out.
Relevant issues
Fixes #886
Type
🐛 Bug Fix
Testing(optional)
Added a new integration test. I made sure the test was failing before the fix.