Skip to content

chore(l1): update execution spec tests 4.0.0 -> 4.3.0 #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

Conversation

DiegoCivi
Copy link
Contributor

Motivation

A new release on the execution spec tests introduces more coverage for Prague EIPs.

Description

When executing make tests now the new 4.3.0 version of the tests is used. As more tests where added in this version, some of them failed so they where added to the skipped array.

Closes #2513

After updating to version 4.3.0 of the executions
tests, there are 12 new tests that fail on REVM.
Version 4.3.0 of execution spec tests adds new tests
that fail when using LEVM. Thos where added to the
array so they can be skipped.
@DiegoCivi DiegoCivi requested a review from a team as a code owner April 24, 2025 21:27
Copy link

Lines of code report

Total lines added: 0
Total lines removed: 10
Total lines changed: 10

Detailed view
+----------------------------------------------------+-------+------+
| File                                               | Lines | Diff |
+----------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_committer.rs         | 387   | -7   |
+----------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/fork_choice.rs | 387   | -3   |
+----------------------------------------------------+-------+------+

@DiegoCivi DiegoCivi changed the title chore(l1): Update execution spec tests 4.0.0 -> 4.3.0 chore(l1): update execution spec tests 4.0.0 -> 4.3.0 Apr 24, 2025
@fmoletta fmoletta added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit 2fc4b21 Apr 25, 2025
18 checks passed
@fmoletta fmoletta deleted the update_spec_tests branch April 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update spec tests to 4.3
4 participants