Skip to content

fix(levm): change CI check for EFTests because London doesn't pass 100% now #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

fix(levm): change CI check for EFTests because London doesn't pass 100% now #2568

merged 4 commits into from
Apr 24, 2025

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Apr 24, 2025 •
edited
Loading

Motivation

  • Fix CI

Description

  • London tests don't pass 100% because new tests have been added and it seems that there is an edge case we are not currently passing. For now I wanted to disable the check that sees if all tests from Prague to London passed and set it to look only for Prague to Paris.
  • Added workflow_dispatch to this workflow so that we can run it manually.

Closes #issue_number

@JereSalo JereSalo added levm Lambda EVM implementation ci Github actions, build, tests, etc labels Apr 24, 2025
@JereSalo JereSalo changed the title fix(levm, ci): change CI check for EFTests because London doesn't pass 100% now fix(levm): change CI check for EFTests because London doesn't pass 100% now Apr 24, 2025
@JereSalo JereSalo marked this pull request as ready for review April 24, 2025 11:13
@JereSalo JereSalo requested a review from a team as a code owner April 24, 2025 11:13
fmoletta
fmoletta reviewed Apr 24, 2025
View reviewed changes
.github/workflows/pr-main_levm.yaml Outdated
@@ -118,7 +119,7 @@ jobs:
- name: Check EF-TESTS from London to Prague is 100%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Check EF-TESTS from London to Prague is 100%
- name: Check EF-TESTS from Paris to Prague is 100%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! e4acd32

@ilitteri ilitteri enabled auto-merge April 24, 2025 14:48
@ilitteri
Copy link
Contributor

It seems that we have a Hive diff with main.

@ilitteri ilitteri added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 214e353 Apr 24, 2025
35 of 37 checks passed
@ilitteri ilitteri deleted the levm/london_not_100 branch April 24, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edg-l edg-l edg-l approved these changes

@ilitteri ilitteri ilitteri approved these changes

@fmoletta fmoletta fmoletta approved these changes

Assignees
No one assigned
Labels
ci Github actions, build, tests, etc levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JereSalo @ilitteri @edg-l @fmoletta