Skip to content

feat(l1): show healing in progress message at set intervals #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 14, 2025

Motivation
We are not able to perform estimations on when healing will end, but we should also not stay completely silent while healing takes place, as this is not very user-friendly.
This PR aims to add messages to inform wether state and storage healing are taking place, at the same pace as we show state sync and rebuild progress. For state sync, pending paths will be shown. These can give an insight on the progress, as the amount of paths will continuously increase as we progress through the trie, but will start gradually decreasing as we near the end of healing. For storages it is a slightly different story as we don't have the full number of pending storages available for showing so we only show the storages currently in the queue.

Description

  • Periodically show amount of paths left during State Healing
  • Periodically show storages in queue during Storage Healing

@fmoletta fmoletta changed the title feat: show healing in progress message at set intervals feat(l1): show healing in progress message at set intervals Apr 14, 2025
Copy link

Lines of code report

Total lines added: 14
Total lines removed: 0
Total lines changed: 14

Detailed view
+------------------------------------------------------+-------+------+
| File                                                 | Lines | Diff |
+------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync/state_healing.rs   | 128   | +5   |
+------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync/storage_healing.rs | 96    | +9   |
+------------------------------------------------------+-------+------+

@fmoletta fmoletta marked this pull request as ready for review April 14, 2025 21:51
@fmoletta fmoletta requested a review from a team as a code owner April 14, 2025 21:51
@fmoletta fmoletta added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 3bbb56e Apr 16, 2025
21 of 23 checks passed
@fmoletta fmoletta deleted the show-healing-in-progress branch April 16, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants