Skip to content

l2(chore): pin solc version to latest #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

avilagaston9
Copy link
Contributor

Motivation

A new version of the Solidity compiler (v0.8.29) has been released. This update modifies the bytecode format, which causes changes in the genesis-l2.json file when launching L2 with make init.

Description

  • Pin Solidity version 0.8.29 in our contracts.
  • Updates genesis-l2.json.

Closes None

@avilagaston9 avilagaston9 self-assigned this Apr 14, 2025
Copy link

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 240.2 ± 4.9 229.9 247.1 1.00
levm_Factorial 799.8 ± 6.8 790.8 813.9 3.33 ± 0.07

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.487 ± 0.085 1.373 1.597 1.00
levm_FactorialRecursive 13.822 ± 0.018 13.797 13.848 9.29 ± 0.53

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 209.7 ± 1.6 208.5 213.7 1.00
levm_Fibonacci 781.4 ± 7.8 771.3 795.2 3.73 ± 0.05

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.0 8.6 8.7 1.00
levm_ManyHashes 16.5 ± 0.2 16.2 16.9 1.90 ± 0.03

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.272 ± 0.028 3.246 3.335 1.00
levm_BubbleSort 5.678 ± 0.037 5.629 5.737 1.74 ± 0.02

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 248.4 ± 1.0 246.9 250.2 1.00
levm_ERC20Transfer 490.2 ± 6.8 480.6 501.2 1.97 ± 0.03

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 140.9 ± 1.2 139.8 143.7 1.00
levm_ERC20Mint 315.1 ± 3.0 311.8 321.2 2.24 ± 0.03

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.026 ± 0.009 1.017 1.048 1.00
levm_ERC20Approval 1.868 ± 0.026 1.838 1.915 1.82 ± 0.03

Main Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 235.4 ± 0.7 233.7 236.3 1.00
levm_Factorial 794.5 ± 2.8 790.0 797.4 3.38 ± 0.02

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.430 ± 0.072 1.331 1.527 1.00
levm_FactorialRecursive 13.782 ± 0.018 13.745 13.814 9.64 ± 0.49

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 205.8 ± 0.5 205.4 207.1 1.00
levm_Fibonacci 788.5 ± 12.3 777.9 818.5 3.83 ± 0.06

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.8 ± 0.1 8.7 8.9 1.00
levm_ManyHashes 16.4 ± 0.2 16.2 16.7 1.87 ± 0.02

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.255 ± 0.017 3.234 3.289 1.00
levm_BubbleSort 5.629 ± 0.046 5.585 5.742 1.73 ± 0.02

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 248.4 ± 1.8 246.2 251.0 1.00
levm_ERC20Transfer 485.0 ± 4.1 477.8 494.0 1.95 ± 0.02

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 141.7 ± 2.6 139.7 147.7 1.00
levm_ERC20Mint 318.9 ± 5.5 313.1 327.6 2.25 ± 0.06

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.039 ± 0.008 1.029 1.057 1.00
levm_ERC20Approval 1.865 ± 0.022 1.846 1.903 1.80 ± 0.02

@avilagaston9 avilagaston9 marked this pull request as ready for review April 14, 2025 21:10
@avilagaston9 avilagaston9 requested a review from a team as a code owner April 14, 2025 21:10
@jrchatruc jrchatruc added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 3df5a16 Apr 16, 2025
53 checks passed
@jrchatruc jrchatruc deleted the chore/l2/pin_solidity_compiler_version branch April 16, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants