Skip to content

Add metrics for execution and storage times per block #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 21, 2025
Merged

Add metrics for execution and storage times per block #2302

merged 8 commits into from
Apr 21, 2025

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Mar 25, 2025

This PR adds logs for each imported block:

  • Transaction count
  • ms/Ggas for execution
  • ms/Ggas for storage
  • Percentage between execution and storage in an imported block

@Arkenan Arkenan requested a review from a team as a code owner March 25, 2025 13:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

Lines of code report

Total lines added: 24
Total lines removed: 0
Total lines changed: 24

Detailed view 
+----------------------------------------+-------+------+
| File                                   | Lines | Diff |
+----------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs | 537   | +24  |
+----------------------------------------+-------+------+

@Arkenan Arkenan requested a review from mpaulucci March 25, 2025 18:35
Oppen
Oppen reviewed Apr 18, 2025
View reviewed changes
crates/blockchain/blockchain.rs
};

let result = inner().await;
let res = self.execute_block(block).await?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that now there will be no log if execution fails. It sounds reasonable but it's not the original behavior.

@fkrause98 fkrause98 added this pull request to the merge queue Apr 21, 2025
Merged via the queue into main with commit 775bc45 Apr 21, 2025
19 checks passed
@fkrause98 fkrause98 deleted the gas-exec-store-metrics branch April 21, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oppen Oppen Oppen approved these changes

@fkrause98 fkrause98 fkrause98 approved these changes

@mpaulucci mpaulucci Awaiting requested review from mpaulucci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arkenan @Oppen @mpaulucci @fkrause98