-
Notifications
You must be signed in to change notification settings - Fork 55
refactor(l2): separated configs for prover_client and sequencer #2269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view
|
fkrause98
approved these changes
Mar 25, 2025
Oppen
reviewed
Mar 25, 2025
ilitteri
reviewed
Mar 26, 2025
ilitteri
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When running the prover_client as a standalone component the
config.toml
wasn't being parsed.Ideally we should parse it before we run the prover_client.
Description
ConfigMode
enum is proposed to parse the .toml for theSequencer
or theProverClient
prover_client_config.toml
and creates a.env.prover
fileCONFIGS_PATH
SEQUENCER_CONFIG_FILE
PROVER_CLIENT_CONFIG_FILE
This change also enables us to change the
SEQUENCER_CONFIG_FILE
easily keeping it in theconfigs
dir and switching theMakefile
's variable. (Useful when testing locally and with a testnet).Closes #2053