feat(l1) Check withdrawals is not missing or null on v2 engine payloads. #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkrause98
changed the title
ElFantasma
reviewed
Jan 3, 2025
|
|
||
| match payload { | ||
| ExecutionPayload { | ||
| withdrawals: None, .. |
There was a problem hiding this comment.
I don't think it is ok to check this here, as this code is run for both V1 and V2 🤔
ElFantasma
approved these changes
Jan 3, 2025
mpaulucci
approved these changes
Jan 3, 2025
rodrigo-o
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The difference between a v1 vs a v2 engine payload is the fact that v2 has a withdrawal field, this PR adds
a check on V2 fork & engine endpoints to check this field is not missing.
Closes #1605