Skip to content

Snap test is flaky #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mpaulucci opened this issue Apr 22, 2025 · 0 comments · Fixed by #2605
Closed

Snap test is flaky #2521

mpaulucci opened this issue Apr 22, 2025 · 0 comments · Fixed by #2605
Labels
ef-tests Hive tests, execution-spec-tests L1 Ethereum client

Comments

@mpaulucci
Copy link
Collaborator

The outcome of this ticket is that the test should be fixed and not be flaky.

See #2520

As part of the debugging, we could run many times with --debug flag until we see the output of the failing tests
@mpaulucci mpaulucci added ef-tests Hive tests, execution-spec-tests L1 Ethereum client labels Apr 22, 2025
@mpaulucci mpaulucci mentioned this issue Apr 22, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 22, 2025
@mpaulucci
ci(l1): skip flaky snap test. (#2520)
755f7e3 
**Motivation**
Snap test is flaky

**Description**
Issue created to reenable it:
#2521
@mpaulucci mpaulucci removed this from ethrex_l1 Apr 23, 2025
@fmoletta fmoletta mentioned this issue Apr 25, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2025
@fmoletta
fix(l1): fcu not triggering sync if snap is enabled + re-enable snap …
521a9b6 
…sync hive test (#2605)

**Motivation**
PR #2426 changed how fork choice & new payload interact with the syncer
and also introduced a bug. If snap sync is enabled, then fork choice
update will never attempt to trigger a sync, so the sync process never
gets started.
This PR fixes the bug and also refactors the sync manager api to better
suit the new use cases
<!-- Why does this pull request exist? What are its goals? -->
* Combine commonly used together `SyncManager` methods `set_head` &
`start_sync` into `sync_to_head`
* Remove unused `SyncManager` method `status` and associated struct
* Make sure sync is triggered during fcu when needed even if snap sync
is enabled
* Re-enable snap sync hive test suite
**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #2521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ef-tests Hive tests, execution-spec-tests L1 Ethereum client
Projects
ethrex_l1
Archived in project
Milestone
No milestone
1 participant
@mpaulucci