Skip to content

Make CI flamegraph use the new load test #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Arkenan opened this issue Apr 15, 2025 · 0 comments · Fixed by #2467
Closed

Make CI flamegraph use the new load test #2466

Arkenan opened this issue Apr 15, 2025 · 0 comments · Fixed by #2467
Assignees
@Arkenan
Labels
performance

Comments

@Arkenan
Copy link
Collaborator

Arkenan commented Apr 15, 2025

No description provided.

@Arkenan Arkenan moved this to In Progress in ethrex_l1 Apr 15, 2025
@Arkenan Arkenan self-assigned this Apr 15, 2025
@Arkenan Arkenan mentioned this issue Apr 15, 2025
Merged
@Arkenan Arkenan moved this from In Progress to In Review in ethrex_l1 Apr 17, 2025
github-merge-queue bot pushed a commit that referenced this issue Apr 21, 2025
@Arkenan
perf(l1,l2): use the new load test for the CI scripts (#2467)
6ef0ee9 
Changes:
- Flamegraph Watcher srcript now:
  - Uses the new load test.
  - Fails if any line fails (e.g. the load test binary panics).
- CI:
  - The flamegraphs are now updated on push to main again.
- Compilation and running is separated to delete the "while not
compiled" polling.
- Reth version is pinned so it does not rely on 2024 features and can be
compiled again.
- Load test:
  - `make` targets now run in release mode.
- now waits until all transactions are included before exciting. There's
a flag to set a timeout.
- All ethrex_l2 references are deleted from CI and the watcher.


Closes #2466
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arkenan Arkenan

Labels
performance
Projects
ethrex_l1
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(l1,l2): use the new load test for the CI scripts lambdaclass/ethrex
1 participant
@Arkenan