Issue a better error message if the target is unsupported. #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following an idea from in lambda-fairy#76, add a sys.rs file, which only gets used if the target isn't recognized, and use `compile_error` to give a meaningful error message instead of cryptically failing on the compiler being unable to open sys.rs. For example, using --target=wasm32-unknown-unknown now gets this error: ```console $ cargo check --target=wasm32-unknown-unknown Checking errno v0.3.11 error: The target OS is "unknown" or "none", so it's unsupported by the errno crate. --> src/sys.rs:8:1 | 8 | compile_error!("The target OS is \"unknown\" or \"none\", so it's unsupported by the errno crate."); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: could not compile `errno` (lib) due to 1 previous error ```
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following an idea from in #76, add a sys.rs file, which only gets used if the target isn't recognized, and use
compile_errorto give a meaningful error message instead of cryptically failing on the compiler being unable to open sys.rs.For example, using --target=wasm32-unknown-unknown now gets this error: