feat: delete key pair #2217
Merged
feat: delete key pair #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 67.71% // Head: 67.71% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 6 6
Lines 508 508
=======================================
Hits 344 344
Misses 137 137
Partials 27 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xiaohan1202
force-pushed
the
del-keypair
branch
from
d69b2b4 to
be077f2
Compare
Signed-off-by: xiaohan <[email protected]>
xiaohan1202
force-pushed
the
del-keypair
branch
from
be077f2 to
72db3f5
Compare
zzjin
reviewed
Dec 8, 2022
| @@ -30,25 +30,25 @@ require ( | |||
| github.com/mitchellh/go-homedir v1.1.0 | |||
| github.com/modood/table v0.0.0-20220527013332-8d47e76dad33 | |||
| github.com/onsi/ginkgo v1.16.5 | |||
| github.com/onsi/gomega v1.20.2 | |||
| github.com/onsi/gomega v1.22.1 | |||
There was a problem hiding this comment.
Add too many go mod changes, may be forgot to run go mod tidy?
zzjin
reviewed
Dec 8, 2022
| @@ -9,8 +9,8 @@ require ( | |||
| github.com/aws/smithy-go v1.12.0 | |||
| github.com/google/uuid v1.3.0 | |||
| github.com/onsi/ginkgo v1.16.5 | |||
| github.com/onsi/gomega v1.20.2 | |||
| golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4 | |||
| github.com/onsi/gomega v1.22.1 | |||
There was a problem hiding this comment.
Update infra go module changes root go.mod a lot. Strange.
fanux
approved these changes
Dec 8, 2022
zzjin
added a commit
to zzjin/sealos
that referenced
this pull request
Dec 8, 2022
Signed-off-by: zzjin <[email protected]>
fanux
pushed a commit
that referenced
this pull request
Dec 8, 2022
Signed-off-by: zzjin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaohan [email protected]