Skip to content

fix: remove detach #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2022
Merged

fix: remove detach #2193

merged 4 commits into from
Dec 6, 2022

Conversation

xiaohan1202
Copy link
Contributor

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Dec 6, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fanux
❌ 孙小涵


孙小涵 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant
Copy link

cla-assistant bot commented Dec 6, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


孙小涵 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@whybeyoung whybeyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples文件 可以分多个文件,不用修改已有的

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 67.71% // Head: 67.71% // No change to project coverage 👍

Coverage data is based on head (a7eccf9) compared to base (7fea853).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2193   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files           6        6           
  Lines         508      508           
=======================================
  Hits          344      344           
  Misses        137      137           
  Partials       27       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fanux fanux merged commit e81a4ce into labring:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants