Skip to content

fix: create instance disk size error and adjust user define disk device name #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 3, 2022

Conversation

whybeyoung
Copy link
Collaborator

@whybeyoung whybeyoung commented Dec 3, 2022

this pr do theses things.

  1. fix create root volume size not working.
  2. user define root/data in Disk.Name rather than Disk.Type , user should not care about deviceName like /dev/xvda or /dev/sdb , they should be generated in the code
  3. add some basic schema validation option: for example, supported 10 disk per machine check, volumeType enums check. disk Type enums check... etc

@whybeyoung whybeyoung changed the title Fix create instance disk size error and adjust user define disk device name fix: create instance disk size error and adjust user define disk device name Dec 3, 2022
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 67.71% // Head: 67.71% // No change to project coverage 👍

Coverage data is based on head (4fa1457) compared to base (0aedab5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2179   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files           6        6           
  Lines         508      508           
=======================================
  Hits          344      344           
  Misses        137      137           
  Partials       27       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fanux fanux merged commit 70b4aaa into labring:main Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants