Skip to content

bug: fixed parse image name and tag #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022
Merged

bug: fixed parse image name and tag #2135

merged 3 commits into from
Nov 22, 2022

Conversation

muicoder
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 67.71% // Head: 67.71% // No change to project coverage 👍

Coverage data is based on head (5b55338) compared to base (858e620).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2135   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files           6        6           
  Lines         508      508           
=======================================
  Hits          344      344           
  Misses        137      137           
  Partials       27       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fanux
Copy link
Member

fanux commented Nov 22, 2022

cri_server.go:154:3: SA4006: this value of `tag` is never used (staticcheck)
  		tag = imageSplitted[1]

@fanux fanux changed the title Fix parseImageNameAndTag Fix parse image name and tag Nov 22, 2022
@fanux fanux changed the title Fix parse image name and tag bug: fixed parse image name and tag Nov 22, 2022
@fanux fanux merged commit 0208f11 into labring:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants