Skip to content

feature(main): add pyament deploy #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Conversation

cuisongliu
Copy link
Collaborator

Signed-off-by: cuisongliu [email protected]

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 67.98% // Head: 67.98% // No change to project coverage 👍

Coverage data is based on head (ebbba45) compared to base (996001c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2035   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files           6        6           
  Lines         506      506           
=======================================
  Hits          344      344           
  Misses        135      135           
  Partials       27       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cuisongliu cuisongliu marked this pull request as ready for review November 3, 2022 14:21
@cuisongliu cuisongliu requested a review from zzjin November 3, 2022 14:24
@cuisongliu cuisongliu linked an issue Nov 3, 2022 that may be closed by this pull request

### How to run

```shell
sealos run docker.io/labring/kustomize:v4.5.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we don't need the callback URL anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to NotifyCallbackURL. It is actually a callback interface for payment to inform us of the status. I think it's more appropriate to keep it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use Notify too, controller will check the payment status every 0.3s, so needn't any notify

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use Notify too, controller will check the payment status every 0.3s, so needn't notify

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use Notify too, controller will check the payment status every 0.3s, so needn't any notify

OK,Let me fix this problem.

@fanux fanux merged commit 4429c8c into labring:main Nov 6, 2022
@cuisongliu cuisongliu deleted the cluster_image_ci branch November 6, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add payment cluster-image
2 participants