feature(main): fix already installed buildah #1968
Conversation
cuisongliu
force-pushed
the
buildah_check
branch
2 times, most recently
from
52cf68a to
1e43845
Compare
Codecov ReportBase: 67.98% // Head: 67.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1968 +/- ##
=======================================
Coverage 67.98% 67.98%
=======================================
Files 6 6
Lines 506 506
=======================================
Hits 344 344
Misses 135 135
Partials 27 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cuisongliu
force-pushed
the
buildah_check
branch
from
1e43845 to
03414c4
Compare
pkg/image/buildah.go
Outdated
| if onceBuildahVersion.GitCommit == "bc5080cc" { | ||
| return true, nil | ||
| } | ||
| return false, errors.New("system buildah is not sealos buildah,please uninstall buildah retry it") |
There was a problem hiding this comment.
What means "system buildah is not sealos buildah...."
fanux
changed the title
|
What can cause problems if buildah is already installed？ |
It may cause the sealos build to be unsuccessful, which is not the same version as the buildah we use, and the parameters are different. |
|
fix #1756 , delete buildah check |
zzjin
changed the title
Signed-off-by: cuisongliu <[email protected]>
cuisongliu
force-pushed
the
buildah_check
branch
from
03414c4 to
7be3afc
Compare
| if onceBuildahVersion.GitCommit == "bc5080cc" { | ||
| return true, nil | ||
| } | ||
| return false, errors.New("System's buildah is not match sealos buildah requirements, please uninstall system's buildah, and retry") |
There was a problem hiding this comment.
But how to fix this issue, user don't know the gitcommit ID，how to reinstall.
|
Signed-off-by: cuisongliu [email protected]