fix: get host arch using SSH for apply/run, apply/reset and apply/scale #1927
Conversation
Signed-off-by: Mercurio <[email protected]>
Signed-off-by: Mercurio <[email protected]>
Signed-off-by: Mercurio <[email protected]>
Codecov ReportBase: 67.69% // Head: 67.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
+ Coverage 67.69% 67.79% +0.09%
==========================================
Files 6 6
Lines 486 503 +17
==========================================
+ Hits 329 341 +12
- Misses 130 134 +4
- Partials 27 28 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SignorMercurio
force-pushed
the
fix/1787
branch
from
7d7f9e8 to
b0d2714
Compare
| clusterSSH := r.cluster.GetSSH() | ||
| sshClient := ssh.NewSSHClient(&clusterSSH, true) | ||
|
|
||
| r.setHostWithIpsPort(masters, []string{v2.MASTER, GetHostArch(sshClient, masters[0])}) |
There was a problem hiding this comment.
If there is something wrong with different nodes and different architectures, I feel traversed, right?
There was a problem hiding this comment.
Sorry, I do not quite understand what you mean. Does "different nodes and different architectures" means that we have masters with different arch or nodes with different arch? I think we currently only support masters/nodes with the same arch.
There was a problem hiding this comment.
Sorry, I do not quite understand what you mean. Does "different nodes and different architectures" means that we have masters with different arch or nodes with different arch? I think we currently only support masters/nodes with the same arch.
At present, it is like this, but in the future, different nodes should be satisfied with different architectures.
There was a problem hiding this comment.
We can handle the mixed architecture case in a single new feature
Should fix #1787.
I'm not sure if these changes cover all the related cases and whether I'm using SSH correctly though.
@cuisongliu PTAL.