feat:account delete payment delay 5 minutes #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 66.45% // Head: 66.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 6 6
Lines 480 480
=======================================
Hits 319 319
Misses 141 141
Partials 20 20 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xiao-jay
changed the title
fanux
reviewed
Oct 11, 2022
| @@ -185,6 +191,24 @@ func (r *AccountReconciler) syncRoleAndRoleBinding(ctx context.Context, name, na | |||
| return nil | |||
| } | |||
|
|
|||
| // DeleteUselessPayment delete payments that exist for more than 5 minutes | |||
| func (r *AccountReconciler) DeleteUselessPayment(ctx context.Context) error { | |||
There was a problem hiding this comment.
DeleteUselessPayment->DeletePayment
fanux
approved these changes
Oct 11, 2022
Signed-off-by: 晓杰 <[email protected]>
|
test finished in my mac，success del payment more than 5 minutes @fanux |
fanux
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 晓杰 [email protected]
Fix #1816
account delete payment more than 5 minutes