refactor: applier #1736
Merged
refactor: applier #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengxsong
force-pushed
the
refactor_applier
branch
from
462db08 to
0ef6182
Compare
Signed-off-by: fengxsong <[email protected]>
fengxsong
force-pushed
the
refactor_applier
branch
from
0ef6182 to
8eb512c
Compare
Codecov ReportBase: 55.37% // Head: 59.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
+ Coverage 55.37% 59.18% +3.81%
==========================================
Files 6 6
Lines 484 468 -16
==========================================
+ Hits 268 277 +9
+ Misses 198 174 -24
+ Partials 18 17 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cuisongliu
approved these changes
Sep 8, 2022
|
Why limit the IP address of the master and node to be different？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fengxsong [email protected]
Refactor
Applierto ensure consistent patterns for flagset