feature(main): add v1.25 k8s support #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
=======================================
Coverage 57.07% 57.07%
=======================================
Files 5 5
Lines 424 424
=======================================
Hits 242 242
Misses 164 164
Partials 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: cuisongliu <[email protected]>
fanux
reviewed
Aug 24, 2022
| @@ -21,7 +21,7 @@ import "fmt" | |||
| const ( | |||
| DefaultBashFmt = "cd %s && bash %s" | |||
| DefaultCPFmt = "mkdir -p %s && cp -rf %s/* %s/" | |||
| DefaultLnFmt = "mkdir -p %s && ln -s %s %s" | |||
| DefaultLnFmt = "ln -s %s %s" | |||
There was a problem hiding this comment.
seems must using mkdir -p %s && cp -rf %s/* %s
fanux
reviewed
Aug 24, 2022
| @@ -96,7 +96,7 @@ func (k *KubeadmRuntime) htpasswd(registry *v1beta1.RegistryConfig) error { | |||
| func (k *KubeadmRuntime) ApplyRegistry() error { | |||
| logger.Info("start to apply registry") | |||
| registry := k.getRegistry() | |||
| lnCmd := fmt.Sprintf(constants.DefaultLnFmt, registry.Data, registry.Data, k.getContentData().RootFSRegistryPath()) | |||
| lnCmd := fmt.Sprintf(constants.DefaultLnFmt, k.getContentData().RootFSRegistryPath(), registry.Data) | |||
There was a problem hiding this comment.
seems should not modify this code
fanux
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cuisongliu [email protected]