feat: auto create dummy link if needed #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fengxsong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1367 +/- ##
=======================================
Coverage 53.09% 53.09%
=======================================
Files 5 5
Lines 420 420
=======================================
Hits 223 223
Misses 181 181
Partials 16 16 Continue to review full report at Codecov.
|
|
The usage scenario is that we want to use lvscare static pod to do load balancing on the control plane. Without this function, we must maintained net link manually, like If these rules are missing, when ipvs forwards tcp requests to the real backend on the local machine, no route to host error will occured. |
cuisongliu
reviewed
Jul 21, 2022
| @@ -42,6 +43,9 @@ func (care *LvsCare) RegisterFlags(fs *pflag.FlagSet) { | |||
| fs.BoolVar(&care.RunOnce, "run-once", false, "run once mode, creating ipvs rules and routes and exit") | |||
| fs.StringVar(&care.VirtualServer, "vs", "", "virtual server like 10.54.0.2:6443") | |||
| fs.StringSliceVar(&care.RealServer, "rs", []string{}, "real server like 192.168.0.2:6443") | |||
| fs.StringVar(&care.IfaceName, "iface", "lvscare", "name of interface to created if needed, "+ | |||
There was a problem hiding this comment.
The default is empty. If not, it may affect the function.
Signed-off-by: fengxsong <[email protected]>
cuisongliu
approved these changes
Jul 21, 2022
cuisongliu
added a commit
to cuisongliu/sealos
that referenced
this pull request
Jul 21, 2022
* Update go1.18 to support workspace (labring#1350) * Update go1.18 to support workspace Signed-off-by: zzjin <[email protected]> * fix linter vendor Signed-off-by: zzjin <[email protected]> * update develop guide about workspace. (labring#1352) Signed-off-by: zzjin <[email protected]> * refactor: clean flag of lvscare (labring#1354) * refactor: clean flag of lvscare Signed-off-by: fengxsong <[email protected]> * fix: ci lints Signed-off-by: fengxsong <[email protected]> * docs: remove badges for lvscare (labring#1358) Signed-off-by: Mercurio <[email protected]> * ci: fix sync_code trigger paths (labring#1360) Signed-off-by: Mercurio <[email protected]> * fix(main): delete logger for isLocal (labring#1359) Signed-off-by: cuisongliu <[email protected]> * fix(main): sync is exists (labring#1361) Signed-off-by: cuisongliu <[email protected]> * add & init sealos desktop frontend project (labring#1357) * init frontend project * impl part of dashboard page layout * logger support fulltext color (labring#1362) * support service modules: auth (labring#1347) 1. add first auth service 2. update workspace to support service/auth 3. move soem code to auth pkg and auth service Signed-off-by: zzjin <[email protected]> * feature(main): local ip not ping (labring#1363) Signed-off-by: cuisongliu <[email protected]> * feat: auto create dummy link if needed (labring#1367) * feat: auto create dummy link if needed Signed-off-by: fengxsong <[email protected]> * fix: make iface arg defaults to empty Signed-off-by: fengxsong <[email protected]> * fix(main): unexpected end of file (labring#1372) * update pull request template to supress showing (labring#1371) Signed-off-by: zzjin <[email protected]> * perf: singleton just fine (labring#1374) Signed-off-by: fengxsong <[email protected]> Co-authored-by: zzjin <[email protected]> Co-authored-by: fengxsong <[email protected]> Co-authored-by: Mercurio <[email protected]> Co-authored-by: cuisongliu <[email protected]> Co-authored-by: 马斯洛 <[email protected]> Co-authored-by: xuehaipeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automatic create a dummy network interface and bind virtual IP to it when any of real server is listening locally(by automatic dectection), setting this parameter to null will skip this behaviour.
Signed-off-by: fengxsong [email protected]