Skip to content

Unite log system with zap. #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2022
Merged

Unite log system with zap. #1300

merged 1 commit into from
Jul 16, 2022

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Jul 12, 2022 •
edited
Loading

first commit

Under development.

  • replace logger with raw zap impl. works with sealos and sealctl
  • replace staging glog.
  • replace logus usage.
  • replace golang's log package usage.

Closes #1293

@codecov
Copy link

codecov bot commented Jul 12, 2022 •
edited
Loading

Codecov Report

Merging #1300 (c7a19d1) into main (e23ce19) will not change coverage.
The diff coverage is n/a.

❗ Current head c7a19d1 differs from pull request most recent head c901e50. Consider uploading reports for the commit c901e50 to get more accurate results

@@           Coverage Diff           @@
##             main    #1300   +/-   ##
=======================================
  Coverage   53.09%   53.09%           
=======================================
  Files           5        5           
  Lines         420      420           
=======================================
  Hits          223      223           
  Misses        181      181           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23ce19...c901e50. Read the comment docs.

@zzjin
Unite log system with zap
c901e50 
* replace sysytem log to logger
* replace old logger code
* remove logrus package
* replace glog with new impl

Signed-off-by: zzjin <[email protected]>
@zzjin zzjin marked this pull request as ready for review July 16, 2022 15:30
@zzjin zzjin requested review from cuisongliu, gitccl, SignorMercurio and Abingcbc and removed request for gitccl July 16, 2022 15:30
@zzjin zzjin changed the title Unite log system with logr+zap Unite log system with zap. Closes #1293 Jul 16, 2022
@zzjin zzjin changed the title Unite log system with zap. Closes #1293 Unite log system with zap. Jul 16, 2022
@cuisongliu cuisongliu merged commit 66012a2 into labring:main Jul 16, 2022
@SignorMercurio SignorMercurio mentioned this pull request Jul 17, 2022
Closed
@zzjin zzjin mentioned this pull request Jul 17, 2022
Closed
zzjin added a commit to zzjin/sealos that referenced this pull request Jul 17, 2022
@zzjin
Unite log system with zap (labring#1300)
cd3144d 
* replace sysytem log to logger
* replace old logger code
* remove logrus package
* replace glog with new impl

Signed-off-by: zzjin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

@SignorMercurio SignorMercurio Awaiting requested review from SignorMercurio

@Abingcbc Abingcbc Awaiting requested review from Abingcbc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Unite all log system
2 participants
@zzjin @cuisongliu