refactor(addon): switch to universal addon

[matejhasul]

Description

Replace template addon with universal addon

Depends on lablabs/terraform-aws-eks-universal-addon#45

Type of change

• A bug fix (PR prefix fix)
• A new feature (PR prefix feat)
• A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
• Adding missing tests or correcting existing tests (PR prefix test)
• Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
• Changes to our CI configuration files and scripts (PR prefix ci)
• Documentation only changes (PR prefix docs)

How Has This Been Tested?

Tested on sandbox environment.

• Deployed lb-controller addon from 2.2.0 with IRSA and tried to update with code from this PR. Plan can be seen below. Changes were then applied and LB functionality was verified - I've created LB service and then checked the targetgroupbindings were created (+ I've checked new LB in AWS console).

Similiar approach was used for pod-identity testing.

TF plan for upgrade (from sandbox-1) with IRSA:

+--------+------------------------------------------------------------------------------------------------------------------------------------------------------------+                                                                                       | CHANGE |                                                                          RESOURCE                                   
                                       |                                                                                       
+--------+------------------------------------------------------------------------------------------------------------------------------------------------------------+                                                                                       
| add    | <prefix>.eks-load-balancer-controller["load-balancer-controller"].module.addon-irsa["aws-load-balancer-controller"].terraform_data.validations |                                                                                       
+        +------------------------------------------------------------------------------------------------------------------------------------------------------------+                                                                                       
|        | <prefix>.eks-load-balancer-controller["load-balancer-controller"].module.addon.terraform_data.validation
s                                      |
+--------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| update | <prefix>.eks-load-balancer-controller["load-balancer-controller"].module.addon.helm_release.argo_application[0]                                |
+--------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
+--------+--------+
| CHANGE | OUTPUT |
+--------+--------+
| update | addon  |
+--------+--------+

Argo_application update (removing parameters and adding skipCrds):

helm:
  parameters: [] -> null
  null -> skipCrds: false

Plan for upgrade with pod identity enabled instead of irsa:

+--------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| CHANGE |                                                                                     RESOURCE                                                                                     |
+--------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| add    | <prefix>.eks-load-balancer-controller["load-balancer-controller"].module.addon-irsa["aws-load-balancer-controller"].terraform_data.validations                       |
+        +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|        | <prefix>.eks-load-balancer-controller["load-balancer-controller"].module.addon.terraform_data.validations                                                            |
+--------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| update | <prefix>.eks-load-balancer-controller["load-balancer-controller"].module.addon-irsa["aws-load-balancer-controller"].aws_eks_pod_identity_association.pod_identity[0] |
+        +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|        | <prefix>.eks-load-balancer-controller["load-balancer-controller"].module.addon.helm_release.argo_application[0]                                                      |
+--------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
+--------+--------+
| CHANGE | OUTPUT |
+--------+--------+
| update | addon  |
+--------+--------+

[jaygridley]

As we discussed we would like to retain EKS Pod Identity support.

[sassdavid]

Hi,

sorry for jumping in here — I just noticed that you’ve recently started using asdf.

Have you heard about mise?
It’s more than just a tool manager; it’s a complete solution for managing your development environment smoothly.

While it primarily helps you manage different versions of various tools — like asdf — it also allows you to manage environment variables and run tasks, making it much more than just a tool installer.
Additionally, mise addresses some of the supply chain risks present in asdf. With asdf, you're often relying on third-party plugins that may execute untrusted code on your system. mise improves on this by using trusted "backends" like the aqua registry and ubi to install tools. When it does need to fall back to the traditional asdf plugin system, it uses forks of those plugins maintained by the mise team, aiming to ensure they are handled more strictly and securely.
It also supports using precompiled binaries for most tools — for example, if your system supports it, you can install a precompiled Python version, saving time and avoiding unnecessary builds.

Please take a look and consider using mise instead of asdf.
You can find more details here and here.

You can also find a more detailed comparison here.

[jaygridley]

Hello @sassdavid, thanks for introducing mise. Looks as a good alternative. We will evaluate it internally if it would fit our needs.

[matejhasul]

@jaygridley I've tested (and prepared moved resources) only for helm installation method. Should I take care also for 2 remaining methods?

[jaygridley]

@jaygridley I've tested (and prepared moved resources) only for helm installation method. Should I take care also for 2 remaining methods?

Yes, we should cover all methods

[matejhasul]

@jaygridley I've tested (and prepared moved resources) only for helm installation method. Should I take care also for 2 remaining methods?

Yes, we should cover all methods

All installation methods tested with cluster-autoscaler addon -> moved blocks updated accordingly.

[jaygridley]

LGTM