fix(kube): add required interactivemode for exec (#2264)

* fix(kube): add required interactivemode for exec

Signed-off-by: Christopher Haar <[email protected]>

* style(lint): fix linter for new golangci-lint

Signed-off-by: Christopher Haar <[email protected]>

---------

Signed-off-by: Christopher Haar <[email protected]>
Co-authored-by: Jim Bugwadia <[email protected]>
Co-authored-by: Charles-Edouard Brétéché <[email protected]>

Author: 3 people

.golangci.yml

@@ -28,7 +28,6 @@ linters:
     - noctx
     - nolintlint
     - nosprintfhostport
-    # - paralleltest
     - staticcheck
     - thelper
     - tparallel

pkg/utils/rest/config.go

@@ -40,10 +40,11 @@ func Save(cfg *rest.Config, w io.Writer) error {
 	}
 	if cfg.ExecProvider != nil {
 		execConfig = &api.ExecConfig{
-			Command:    cfg.ExecProvider.Command,
-			Args:       cfg.ExecProvider.Args,
-			APIVersion: cfg.ExecProvider.APIVersion,
-			Env:        []api.ExecEnvVar{},
+			Command:         cfg.ExecProvider.Command,
+			Args:            cfg.ExecProvider.Args,
+			APIVersion:      cfg.ExecProvider.APIVersion,
+			Env:             []api.ExecEnvVar{},
+			InteractiveMode: api.ExecInteractiveMode(cfg.ExecProvider.InteractiveMode),
 		}
 		for _, envVar := range cfg.ExecProvider.Env {
 			execConfig.Env = append(execConfig.Env, api.ExecEnvVar{

pkg/utils/rest/config_test.go

@@ -185,6 +185,7 @@ func TestSave(t *testing.T) {
 					Name:  "foo",
 					Value: "bar",
 				}},
+				InteractiveMode: api.IfAvailableExecInteractiveMode,
 			},
 		},
 		wantW: `
@@ -212,6 +213,7 @@ users:
       env:
       - name: foo
         value: bar
+      interactiveMode: IfAvailable
       provideClusterInfo: false
 `,
 	}}