chore(deps): update dependencies and improve linter configuration (#2304)

* chore(deps): update actions/setup-go to v5.3.0, golangci-lint-action to v6.5.0

Signed-off-by: A. Singh <[email protected]>

* chore(linter): replace exportloopref with copyloopvar and tenv with usetesting in .golangci.yml

Signed-off-by: A. Singh <[email protected]>

* test(report): use t.TempDir() instead of os.MkdirTemp() in TestSave

Signed-off-by: A. Singh <[email protected]>

---------

Signed-off-by: A. Singh <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Co-authored-by: Charles-Edouard Brétéché <[email protected]>

Author: A-5ingh

.golangci.yml

@@ -30,12 +30,12 @@ linters:
     - nosprintfhostport
     # - paralleltest
     - staticcheck
-    - tenv
     - thelper
     - tparallel
     - typecheck
     - unconvert
     - unused
+    - usetesting
     - wastedassign
     - whitespace
 

pkg/report/report_test.go

@@ -130,8 +130,7 @@ func TestSave(t *testing.T) {
 		format:  v1alpha2.ReportFormatType("xyz"),
 		wantErr: true,
 	}}
-	path, err := os.MkdirTemp("", "")
-	assert.NoError(t, err)
+	path := t.TempDir()
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			err := Save(tt.report, tt.format, path, string(tt.format))