Skip to content

chore: Sort telemetry.kyma-project.io API types (v1alpha1 and v1beta1) #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 25, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Oct 24, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Add LogPipeline prefix to LogPipeline subtypes in v1alpha1 to unify it with v1beta1
  • Rename DiagnosticMetric -> MetricPipelineIstioInputDiagnosticMetrics
  • Apply the following sort order in order to have a better overview of difference between v1alpha1 and v1beta1:
  1. init func
  2. FooList
  3. Foo
  4. FooSpec
  5. FooSpec subtypes
  6. FooStatus
  • Add a missing comment to OTLP input in LogPipeline

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 24, 2024
@skhalash skhalash marked this pull request as ready for review October 25, 2024 11:01
@skhalash skhalash requested a review from a team as a code owner October 25, 2024 11:01
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
@skhalash skhalash added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
@skhalash skhalash added this to the 1.27.0 milestone Oct 25, 2024
@skhalash skhalash added area/metrics MetricPipeline area/logs LogPipeline area/traces TracePipeline kind/chore Categorizes issue or PR as related to a chore. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 25, 2024
@skhalash skhalash enabled auto-merge (squash) October 25, 2024 12:43
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 25, 2024
@skhalash skhalash merged commit 82dc218 into kyma-project:main Oct 25, 2024
42 checks passed
@skhalash skhalash deleted the sort-api-types branch October 28, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants