Skip to content

fix: Get rid of spammy RBAC log #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

skhalash
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • Operator container was printing the following log message:
{"level":"ERROR","timestamp":"2024-10-22T15:15:54Z","caller":"cache/reflector.go:158","message":"Unhandled Error","logger":"UnhandledError","error":"pkg/mod/k8s.io/[email protected]/tools/
cache/reflector.go:243: Failed to watch *v1.CustomResourceDefinition: unknown (get customresourcedefinitions.apiextensions.k8s.io)"

Even though the watch permissions is not required, the operator is already granted get and list permissions, so adding watch to satisfy controller-runtime is fine.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash requested a review from a team as a code owner October 22, 2024 15:51
@skhalash skhalash added this to the 1.27.0 milestone Oct 22, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2024
@skhalash skhalash added area/manager Manager or module changes kind/bug Categorizes issue or PR as related to a bug. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Oct 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 22, 2024
@skhalash skhalash enabled auto-merge (squash) October 22, 2024 19:22
@skhalash skhalash merged commit 5d0f33d into kyma-project:main Oct 22, 2024
60 of 74 checks passed
@skhalash skhalash deleted the fix-crd-rbac branch October 22, 2024 19:35
@a-thaler a-thaler modified the milestones: 1.27.0, 1.26.1 Oct 23, 2024
TeodorSAP pushed a commit to TeodorSAP/telemetry-manager that referenced this pull request Oct 23, 2024
@a-thaler a-thaler modified the milestones: 1.26.1, 1.27.0 Oct 23, 2024
@a-thaler
Copy link
Collaborator

Backported to 1.26.1 by #1550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants