-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only set +whole-archive on rust 1.82+ #4780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d3d0e6
to
04b9b4b
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4780 +/- ##
==========================================
- Coverage 86.34% 86.34% -0.01%
==========================================
Files 1399 1399
Lines 60296 60296
Branches 7417 7416 -1
==========================================
- Hits 52062 52060 -2
- Misses 8068 8070 +2
Partials 166 166 ☔ View full report in Codecov by Sentry. |
daa340f
to
622e744
Compare
622e744
to
764a43a
Compare
Benchmark ResultMaster commit hash:
|
andyfengHKU
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason CI for #4779 is taking a long time and I think I've found a better solution in the meantime.
There's a crate that can be used to do conditional checks on the rust compiler version, so we can conditionally set the +whole-archive linker flag only on rust 1.82 and newer versions, which fixes the incompatibility with rust <1.74.