Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set +whole-archive on rust 1.82+ #4780

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

benjaminwinger
Copy link
Collaborator

For some reason CI for #4779 is taking a long time and I think I've found a better solution in the meantime.

There's a crate that can be used to do conditional checks on the rust compiler version, so we can conditionally set the +whole-archive linker flag only on rust 1.82 and newer versions, which fixes the incompatibility with rust <1.74.

This comment was marked as off-topic.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (977ef30) to head (764a43a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4780      +/-   ##
==========================================
- Coverage   86.34%   86.34%   -0.01%     
==========================================
  Files        1399     1399              
  Lines       60296    60296              
  Branches     7417     7416       -1     
==========================================
- Hits        52062    52060       -2     
- Misses       8068     8070       +2     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger force-pushed the rust-conditional-build branch 2 times, most recently from daa340f to 622e744 Compare January 23, 2025 20:17
Copy link

Benchmark Result

Master commit hash: 8887b45b7b9326662fa79de921221f366e023fa9
Branch commit hash: 39818b201ff97b9f4dc14d8d7f18e80a265502c1

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 690.67 698.26 -7.58 (-1.09%)
aggregation q28 6077.13 6080.69 -3.55 (-0.06%)
filter q14 125.83 133.65 -7.82 (-5.85%)
filter q15 124.95 132.18 -7.23 (-5.47%)
filter q16 303.30 307.18 -3.88 (-1.26%)
filter q17 448.99 453.77 -4.78 (-1.05%)
filter q18 1903.82 1912.94 -9.13 (-0.48%)
filter zonemap-node 89.06 98.63 -9.58 (-9.71%)
filter zonemap-node-lhs-cast 89.37 98.85 -9.47 (-9.58%)
filter zonemap-node-null 87.15 93.96 -6.81 (-7.25%)
filter zonemap-rel 5761.69 5805.77 -44.08 (-0.76%)
fixed_size_expr_evaluator q07 571.66 581.81 -10.15 (-1.74%)
fixed_size_expr_evaluator q08 803.89 809.63 -5.74 (-0.71%)
fixed_size_expr_evaluator q09 804.27 811.20 -6.94 (-0.85%)
fixed_size_expr_evaluator q10 236.94 244.58 -7.64 (-3.12%)
fixed_size_expr_evaluator q11 231.40 237.12 -5.72 (-2.41%)
fixed_size_expr_evaluator q12 226.68 234.14 -7.46 (-3.19%)
fixed_size_expr_evaluator q13 1464.72 1471.61 -6.89 (-0.47%)
fixed_size_seq_scan q23 113.18 119.17 -5.99 (-5.03%)
join q29 608.64 617.80 -9.16 (-1.48%)
join q30 10813.43 10913.70 -100.27 (-0.92%)
join q31 7.52 6.37 1.14 (17.95%)
join SelectiveTwoHopJoin 60.29 53.40 6.89 (12.91%)
ldbc_snb_ic q35 2576.75 2587.94 -11.19 (-0.43%)
ldbc_snb_ic q36 453.74 483.60 -29.86 (-6.17%)
ldbc_snb_is q32 6.85 6.59 0.26 (3.89%)
ldbc_snb_is q33 15.29 15.66 -0.37 (-2.36%)
ldbc_snb_is q34 1.38 1.38 0.00 (0.22%)
multi-rel multi-rel-large-scan 1291.59 1343.84 -52.25 (-3.89%)
multi-rel multi-rel-lookup 11.35 44.02 -32.67 (-74.22%)
multi-rel multi-rel-small-scan 85.69 60.27 25.43 (42.19%)
order_by q25 133.77 142.75 -8.98 (-6.29%)
order_by q26 458.51 466.59 -8.07 (-1.73%)
order_by q27 1471.79 1467.64 4.15 (0.28%)
recursive_join recursive-join-bidirection 316.04 287.57 28.47 (9.90%)
recursive_join recursive-join-dense 7463.50 7462.52 0.98 (0.01%)
recursive_join recursive-join-path 23818.47 23499.67 318.80 (1.36%)
recursive_join recursive-join-sparse 1054.21 1051.12 3.10 (0.29%)
recursive_join recursive-join-trail 7419.24 7432.43 -13.19 (-0.18%)
scan_after_filter q01 174.10 179.40 -5.29 (-2.95%)
scan_after_filter q02 158.79 166.06 -7.26 (-4.37%)
shortest_path_ldbc100 q37 92.36 92.65 -0.30 (-0.32%)
shortest_path_ldbc100 q38 344.64 383.31 -38.66 (-10.09%)
shortest_path_ldbc100 q39 63.53 63.18 0.35 (0.55%)
shortest_path_ldbc100 q40 435.52 389.82 45.70 (11.72%)
var_size_expr_evaluator q03 2087.67 2087.81 -0.14 (-0.01%)
var_size_expr_evaluator q04 2213.28 2208.76 4.52 (0.20%)
var_size_expr_evaluator q05 2631.93 2610.24 21.69 (0.83%)
var_size_expr_evaluator q06 1333.81 1341.00 -7.18 (-0.54%)
var_size_seq_scan q19 1456.17 1455.70 0.47 (0.03%)
var_size_seq_scan q20 2643.59 2733.72 -90.13 (-3.30%)
var_size_seq_scan q21 2269.55 2322.48 -52.93 (-2.28%)
var_size_seq_scan q22 125.52 127.67 -2.15 (-1.68%)

@andyfengHKU andyfengHKU merged commit 95759e1 into master Jan 24, 2025
25 checks passed
@andyfengHKU andyfengHKU deleted the rust-conditional-build branch January 24, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants