fix(meshratelimit): add warning log about status code #13958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 400 Signed-off-by: Lukasz Dziedziak <[email protected]>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
slonka
reviewed
Jul 16, 2025
| @@ -9,6 +11,35 @@ func (t *MeshRateLimitResource) Deprecations() []string { | |||
| var deprecations []string | |||
| if len(pointer.Deref(t.Spec.From)) > 0 { | |||
| deprecations = append(deprecations, "'from' field is deprecated, use 'rules' instead") | |||
| for i, rule := range pointer.Deref(t.Spec.From) { | |||
| if rule.Default.Local != nil && isStatusInvalid(pointer.Deref(rule.Default.Local)) { | |||
There was a problem hiding this comment.
you don't need pointer.Deref if you just checked that rule.Default.Local is not nil
| @@ -9,6 +11,35 @@ func (t *MeshRateLimitResource) Deprecations() []string { | |||
| var deprecations []string | |||
| if len(pointer.Deref(t.Spec.From)) > 0 { | |||
| deprecations = append(deprecations, "'from' field is deprecated, use 'rules' instead") | |||
| for i, rule := range pointer.Deref(t.Spec.From) { | |||
| if rule.Default.Local != nil && isStatusInvalid(pointer.Deref(rule.Default.Local)) { | |||
| deprecations = append(deprecations, fmt.Sprintf("'spec.from[%d].default.local.http.requestRate.status' must be 400 or higher. Please update your configuration.", i)) | |||
There was a problem hiding this comment.
should we mention why that's the case? that envoy uses 429 when that happens?
There was a problem hiding this comment.
should this be in deprecations or in warnings?
There was a problem hiding this comment.
warnings are not presented anywhere so it might not be a solution here
Signed-off-by: Lukasz Dziedziak <[email protected]>
slonka
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the status is lower than 400 envoy fallback to 429. We shouldn't allow setting incorrect status
Implementation information
Added log information that setting status lower than 400 is not supported
Supporting documentation
part of: ##13319