This repository was archived by the owner on Mar 1, 2024. It is now read-only.
Disable restart action in VM import status #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
do-not-merge/work-in-progress
pcbailey
force-pushed
the
disable-actions-on-vm-import
branch
from
1d2744c to
d709a09
Compare
atiratree
reviewed
Mar 27, 2019
pcbailey
force-pushed
the
disable-actions-on-vm-import
branch
from
d709a09 to
ca4e68c
Compare
pcbailey
force-pushed
the
disable-actions-on-vm-import
branch
from
ca4e68c to
f038780
Compare
pcbailey
changed the title
kubevirt-bot
removed
the
do-not-merge/work-in-progress
atiratree
approved these changes
Mar 28, 2019
kubevirt-bot
added
the
needs-rebase
pcbailey
force-pushed
the
disable-actions-on-vm-import
branch
from
f038780 to
da3c1b9
Compare
kubevirt-bot
removed
the
needs-rebase
atiratree
reviewed
Apr 2, 2019
| } | ||
|
|
||
| const pods = actionArgs[PodModel.kind]; | ||
| const importerPods= getVmImporterPods(actionArgs[PodModel.kind], vm); |
There was a problem hiding this comment.
you do not have to supply importerPods anymore if you supply all pods. Please see getVmStatus
|
|
||
| const isImporting = (vm, actionArgs) => { | ||
| const status = getStatusForVm(vm, actionArgs); | ||
| return status ? status.status === VM_STATUS_IMPORTING : false; |
There was a problem hiding this comment.
shorthand? status && status.status === VM_STATUS_IMPORTING
| @@ -69,6 +69,7 @@ const VMRow = ({obj: vm}) => { | |||
| resources={[ | |||
| getResource(VirtualMachineInstanceModel, {name, namespace, isList: false}), | |||
| migrationResources, | |||
| getResource(PodModel, {namespace, matchLabels: {[CDI_KUBEVIRT_IO]: 'importer'}}), | |||
There was a problem hiding this comment.
I think it would be better to select just pods without the importer labels. Because it might be confusing when somebody gets to use getVmStatus method in menu-actions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following bug: https://bugzilla.redhat.com/show_bug.cgi?id=1673921
Depends on: kubevirt/web-ui-components#296