This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Remove Overview/HealthBody and use Dashboard/HealthBody in Compliace #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1350
💛 - Coveralls |
mareklibra
reviewed
Apr 18, 2019
| @@ -4,9 +4,5 @@ export { ClusterOverviewContext } from './ClusterOverviewContext'; | |||
| // TODO move all these mocked data to component fixtures once they are not needed in web-ui | |||
| // we do not include fixture files in build so we cannot reuse their mocked data | |||
| export const complianceData = { | |||
There was a problem hiding this comment.
Can we get rid of this at all?
There was a problem hiding this comment.
Compliance is still just hardcoded, so no, we cannot - or I could hardcode it into compliance component itself (and not connect it to provider).
There was a problem hiding this comment.
ok, got it. Let's keep it then.
mareklibra
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.