This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Add subsystem health #362
Merged
Add subsystem health #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1344
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1259
💛 - Coveralls |
yaacov
force-pushed
the
subsystem-health
branch
from
fbb7328 to
85b5c58
Compare
This was referenced Apr 16, 2019
yaacov
force-pushed
the
subsystem-health
branch
from
85b5c58 to
6ec0cac
Compare
|
Ref: kubevirt/web-ui#312 |
yaacov
force-pushed
the
subsystem-health
branch
from
eb69abe to
783e0a2
Compare
rawagner
suggested changes
Apr 17, 2019
| title: PropTypes.string.isRequired, | ||
| }; | ||
|
|
||
| export default DashboardCardTitleSeeAll; |
There was a problem hiding this comment.
can you remove this default export and export DashboardCardTitleSeeAll itself ? we usually do not use default exports
| @@ -0,0 +1,46 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
SubsystemHealth component should go under Dashboard folder
|
moved subsystem into dashboard, @rawagner please re review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subsystem health
Requires kubevirt/web-ui#312
Ref: https://jira.coreos.com/browse/CNV-1151
Screenshots:
